Simple Rescue System#2403
Merged
kobliha merged 5 commits intoagama-project:masterfrom May 26, 2025
Merged
Conversation
- Implements a rescue system by booting to the Installer Live Media image with special systemd parameters that disable booting to the graphical mode and starting Agama service - Some services are keps, such as DUD and Self-Update
imobachgs
reviewed
May 26, 2025
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
It looks fine. Did you try it?
Please, update the changes file.
Contributor
Author
|
I tried that just manually on a Kernel command-line |
imobachgs
previously approved these changes
May 26, 2025
imobachgs
dismissed
their stale review
Discussing on IRC about whether it will work.
lslezak
approved these changes
May 26, 2025
Contributor
lslezak
left a comment
lslezak
left a comment
There was a problem hiding this comment.
Looks good as the initial implementation for some rescue system.
However there are still some questions:
- Which services should be actually started in the rescue mode? Should we e.g. configure the network?
- Systemd already provides it's own rescue mode, boot with
systemd.unit=rescue.target live.password=password(The rescue target requires a configured root password, that's why I updated thelive-password.servicefile in this PR to allow setting the password in the rescue mode as well.) - Implementation detail: Maybe we should define a separate systemd target for this?
Contributor
Author
|
Thanks @lslezak, yes I thought about a special target too, but it's a bigger thing and requires a better plan, more impl. time and better testing. I simply went for the simplest solution as we don't have the requirements yet. Anyway, you should open an issue or a discussion here at GH for the topic. |
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current media do not have a Rescue System but users are asking for it
Solution
This PR does not implement any special Rescue System. It only reuses what we already have and prevents Agama from starting.
Testing